[PATCH] D42740: Implement a case-folding version of DJB hash

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 1 07:35:21 PST 2018


probinson added a comment.

Header looks fine.



================
Comment at: utils/unicode-case-fold.py:5
+
+Parses a the database and generates a C++ function which implements the case
+folding algorithm. The database entries are of the form:
----------------
"Parses the database..."


================
Comment at: utils/unicode-case-fold.py:42
+
+# Computes the shift (to_char - from_char) in a mapping
+def shift(mapping):
----------------
Missing full-stop.


================
Comment at: utils/unicode-case-fold.py:103
+
+    # incompatible stride, start a new block
+    dump_block(current_block)
----------------
Capitalize, full-stop.


Repository:
  rL LLVM

https://reviews.llvm.org/D42740





More information about the llvm-commits mailing list