[PATCH] D40975: [LangRef] Reflect the changes in the TBAA info format

David Kreitzer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 1 05:29:03 PST 2018


DavidKreitzer added a comment.

This looks like a nice change.



================
Comment at: docs/LangRef.rst:4680
+                             //        Offset=12, Size=4)
+      outer->inner.f = 0.0;  // tag7: (BaseType=Outer, AccessType=Int,
+                             //        Offset=16, Size=4)
----------------
Potentially confusing typo here. AccessType should be Float.


================
Comment at: docs/LangRef.rst:4705
+              (Type=Double, Offset=4,  Size=8),
+              (Type=Inner,  Offset=12, Size=8)}
+
----------------
The descriptor for U should be added here as well.


================
Comment at: docs/LangRef.rst:4744
+    !6 = !{ !1, i64 20, !"Outer", !2, i64 0, i64 4, !3, i64 4, i64 8, !5, i64 12, i64 8 }
+
+The first operand is the ``MDNode`` of the parent descriptor or the TBAA root.
----------------
The descriptor for U should probably be added here also.


https://reviews.llvm.org/D40975





More information about the llvm-commits mailing list