[PATCH] D42667: SplitKit: Fix liveness recomputation in some remat cases.

[Krzysztof Parzyszek via Phabricator via llvm-commits]

kparzysz added a comment.

This looks ok to me, just a couple of nitpicks.



================
Comment at: lib/CodeGen/SplitKit.cpp:1458
+      VNInfo *PredVNI = ParentLI.getVNInfoBefore(PredEnd);
+      assert(PredVNI && "Value available in PhiVNI predecessor");
+      if (Visited.insert(PredVNI).second)
----------------
In the text of the assertion, should it be "value not available..."?  Also there is no variable PhiVNI.


================
Comment at: lib/CodeGen/SplitKit.cpp:1462
+    }
+  } while(!WorkList.empty());
+}
----------------
Missing space between while and (.


Repository:
  rL LLVM

https://reviews.llvm.org/D42667