[PATCH] D42481: [DebugInfo] Add basic support for DWARF 5 .debug_rnglists dumping

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added inline comments.


================
Comment at: include/llvm/DebugInfo/DWARF/DWARFDebugRnglists.h:23
+public:
+  struct BoundedRange {
+    uint64_t Start;
----------------
jhenderson wrote:
> JDevlieghere wrote:
> > As this is so similar to `DWARFAddressRange` it would be nice if we could reuse that in some way.  We already have infrastructure to verify these entries for things like overlap that we might want to reuse in the verifier. 
> Good idea. I wonder if DWARFAddressRange should be moved into its own file, since it's not specific to the DWARFDebugRangeList class?
Sounds like a good idea!


================
Comment at: lib/DebugInfo/DWARF/DWARFDebugRnglists.cpp:117
+  const uint32_t HexWidth = HeaderData.AddrSize * 2;
+  for (const auto &List : Ranges) {
+    for (const auto &Entry : List) {
----------------
jhenderson wrote:
> JDevlieghere wrote:
> > Same here and on the next line.
> There are two lines in the outer loop!
Right, missed the last `OS << ...` underneath :-) 


Repository:
  rL LLVM

https://reviews.llvm.org/D42481