[PATCH] D42769: Create a VSIX Installer for the VS Integration

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 31 16:46:33 PST 2018


zturner updated this revision to Diff 132296.
zturner added a comment.

I made a few minor changes in this update.

1. Instead of duplicating `Toolset.targets` in both the x86 and x64 platform folders, have a common one at the top level that both of them import.  They're actually completely identical.

2. Rename `Clang.Cpp.*` to `LLVM.Cpp.*`.  The reason being that eventually we will integrate LLD, and this is more than just clang.

3. Removed a dead file `AssemblyInfo.cs` which the IDE adds by default, but isn't necessary for us since we don't actually have any code.

4. Added some newlines at the end of files that didn't have them (don't really want to mess with the `.cs` file since it's auto generated, and the IDE will just keep deleting the newline every time you do something to the file)


https://reviews.llvm.org/D42769

Files:
  llvm/tools/msbuild/Clang.Cpp.Common.props
  llvm/tools/msbuild/Clang.Toolset.x64.props
  llvm/tools/msbuild/Clang.Toolset.x86.props
  llvm/tools/msbuild/LLVM.props
  llvm/tools/msbuild/Toolset.targets
  llvm/tools/msbuild/clang-cl.xml
  llvm/tools/msbuild/llvm.sln
  llvm/tools/msbuild/llvm/.gitignore
  llvm/tools/msbuild/llvm/LLVM.Cpp.Common.props
  llvm/tools/msbuild/llvm/LLVM.Cpp.Common.targets
  llvm/tools/msbuild/llvm/LLVM.props
  llvm/tools/msbuild/llvm/Platformx64/Toolset.props
  llvm/tools/msbuild/llvm/Platformx64/Toolset.targets
  llvm/tools/msbuild/llvm/Platformx86/Toolset.props
  llvm/tools/msbuild/llvm/Platformx86/Toolset.targets
  llvm/tools/msbuild/llvm/clang-cl.xml
  llvm/tools/msbuild/llvm/license.txt
  llvm/tools/msbuild/llvm/llvm.csproj
  llvm/tools/msbuild/llvm/source.extension.vsixmanifest

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42769.132296.patch
Type: text/x-patch
Size: 16658 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180201/b89a10a2/attachment.bin>


More information about the llvm-commits mailing list