[PATCH] D36351: [lld][ELF] Add profile guided section layout

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 31 16:36:16 PST 2018


Rui Ueyama <ruiu at google.com> writes:

> Sorry for the belated response
>
> I experienced perhaps too many problems with this patch, for example, it's
> was too unstable (it sometimes crashes), it didn't compile in the first
> place, it lacked the instructions how to test it, it lacked some required
> file, etc. and it just took too much time even to just run it. Do you mind
> if I ask you to prepare a patch more carefully? Ideally it should come with
> a script that builds everything from source with and without profile-guided
> optimization to demonstrate the feature, as I partly did in my github
> repository for you.

That is the gist of why I asked for a patch that reads the call graph
from a text file and is stand alone.

That way if a crash is found (it was), it is easy to create a testcase.

Cheers,
Rafael


More information about the llvm-commits mailing list