[PATCH] D42260: [JumpThreading] Don't select an edge that we know we can't thread
Keno Fischer via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 31 14:22:43 PST 2018
loladiro added inline comments.
================
Comment at: test/Transforms/JumpThreading/header-succ.ll:40
+
+; We also need to check the opposite order of the branches, in the switch
+; instruction because jump-threading relies on that to decide which edge to
----------------
haicheng wrote:
> It seems to me that two test cases are identical. Did you forget flip the branch condition or destinations?
Argh, yes I think I meant to flip the order of the entries in the `switch`. Thanks for the catch. I'll fix it up for the committed version.
Repository:
rL LLVM
https://reviews.llvm.org/D42260
More information about the llvm-commits
mailing list