[PATCH] D42759: [CGP] Split large structs to sink more GEPs

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 31 12:36:49 PST 2018


efriedma added inline comments.


================
Comment at: lib/CodeGen/CodeGenPrepare.cpp:3758
+          PointerType *BaseTy = cast<PointerType>(Base->getType());
+          if (BaseTy->getElementType()->isStructTy()) {
+            Instruction *BaseI = dyn_cast<Instruction>(Base);
----------------
I haven't really reviewed the whole patch closely, so I might be missing something, but why does it matter that the element type is a struct, as opposed to something else large like an array?


Repository:
  rL LLVM

https://reviews.llvm.org/D42759





More information about the llvm-commits mailing list