[PATCH] D42713: LTO: Include dso-local bit in ThinLTO cache key.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc marked an inline comment as done.
pcc added inline comments.


================
Comment at: llvm/lib/LTO/LTO.cpp:181
+    for (const ValueInfo &VI : GS->refs()) {
+      AddUnsigned(VI.isDSOLocal());
       AddUsedCfiGlobal(VI.getGUID());
----------------
tejohnson wrote:
> Is it necessary to do this for all refs, rather than just for each DefinedGlobals summary (like we do for the linkage below)?
Yes because dso-local generally affects the code generated for references to globals.


https://reviews.llvm.org/D42713