[PATCH] D42754: [SelectionDAG] Fix UpdateChains handling of TokenFactors

Nirav Dave via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 31 11:27:20 PST 2018


niravd created this revision.
niravd added reviewers: jonpa, RKSimon, bogner.
Herald added a subscriber: hiraditya.

In Instruction Selection UpdateChains replaces all matched Nodes'
chain references including interior token factors and deletes them.
This may allow nodes which depend on these interior nodes but are not
part of the set of matched nodes to be left with a dangling dependence.
Avoid this by doing the replacement for matched non-TokenFactor nodes.

Fixes PR36164.


Repository:
  rL LLVM

https://reviews.llvm.org/D42754

Files:
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
  llvm/test/CodeGen/SystemZ/pr36164.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42754.132232.patch
Type: text/x-patch
Size: 6196 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180131/d56117ca/attachment.bin>


More information about the llvm-commits mailing list