[PATCH] D42734: [DebugInfo] Improvements to representation of enumeration types (PR36168)

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: lib/Bitcode/Reader/MetadataLoader.cpp:1200
   case bitc::METADATA_ENUMERATOR: {
-    if (Record.size() != 3)
+    if (Record.size() < 3 || Record.size() > 4)
       return error("Invalid record");
----------------
An alternative implementation would be to stick the isSigned bit into Record[0] & 0x2. This would make the on-disk-representation smaller. There are lots of examples of other entities in the DIType hierarchy that do this.


https://reviews.llvm.org/D42734