[PATCH] D42734: [DebugInfo] Improvements to representation of enumeration types (PR36168)

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: test/DebugInfo/Generic/debug-info-enum.ll:29-39
+; CHECK:         DW_TAG_enumeration_type
+; CHECK-DW2-NOT:   DW_AT_type
+; CHECK-DW4:       DW_AT_type{{.*}}"signed char"
+; CHECK-DW4:       DW_AT_enum_class        (true)
+; CHECK:           DW_AT_name      ("E0")
+; CHECK:         DW_TAG_enumerator
+; CHECK:           DW_AT_name    ("A0")
----------------
Usually we don't mix the CHECK lines in with the IR - though I wouldn't rule it out.

Also usually we provide the C or C++ source (or something like it) in a comment a the top to see at a glance what's being tested)

I actually don't mind this test as-is, but just some ideas.


================
Comment at: test/DebugInfo/X86/enum-class.ll:47
 
-; CHECK: DW_TAG_enumeration_type [6]
+; CHECK: DW_TAG_enumeration_type [7]
 ; CHECK-NOT: DW_AT_enum_class
----------------
Probably just drop the abbreviation number from the test 


Repository:
  rL LLVM

https://reviews.llvm.org/D42734