[PATCH] D42095: [WebAssembly] Output provisional table to match LLD relocatable output

[Nicholas Wilson via Phabricator via llvm-commits]

ncw added a comment.

Thanks! Description looks good. (Could be "affect" :) )



================
Comment at: lib/MC/WasmObjectWriter.cpp:502
-    if (!IndirectSymbolIndices.count(RelEntry.Symbol))
-      report_fatal_error("symbol not found in table index space: " +
-                         RelEntry.Symbol->getName());
----------------
sbc100 wrote:
> I guess this error was removed because it should never happen right?
> 
> And converting it to an assert wouldn't be very useful?
> 
Hmm, maybe it would be better to keep the check. In fact, there are several places where we do a check using "!thing.count()", when we could instead be using "find" to do the lookup only once. That would be ideal I guess, maybe with "findOrAbort" static helper function.


Repository:
  rL LLVM

https://reviews.llvm.org/D42095