[PATCH] D42095: [WebAssembly] Output provisional table to match LLD relocatable output

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 31 10:36:34 PST 2018


sbc100 added inline comments.


================
Comment at: lib/MC/WasmObjectWriter.cpp:502
-    if (!IndirectSymbolIndices.count(RelEntry.Symbol))
-      report_fatal_error("symbol not found in table index space: " +
-                         RelEntry.Symbol->getName());
----------------
I guess this error was removed because it should never happen right?

And converting it to an assert wouldn't be very useful?



Repository:
  rL LLVM

https://reviews.llvm.org/D42095





More information about the llvm-commits mailing list