[PATCH] D42711: AMDGPU: Support target triple OS component cuda

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In https://reviews.llvm.org/D42711#993538, @yaxunl wrote:

> In https://reviews.llvm.org/D42711#993524, @arsenm wrote:
>
> > In https://reviews.llvm.org/D42711#993511, @yaxunl wrote:
> >
> > > In https://reviews.llvm.org/D42711#993470, @jlebar wrote:
> > >
> > > > In https://reviews.llvm.org/D42711#993457, @b-sumner wrote:
> > > >
> > > > > Changing those selections make sense to me since was are adding support for a completely new and different target.
> > > >
> > > >
> > > > As one of the CUDA maintainers, this also makes sense to me, although we're going to need tests and (to the extent possible) wrapper functions so that it doesn't break.
> > >
> > >
> > > There is another concern. If we need to identify IR originated from CUDA in AMDHSA OS, what should we do? Introduce CUDA again as an environment component?
> >
> >
> > There shouldn't be any reason to do this. The IR shouldn't really care what the source was.
>
>
> Then why do we need opencl environment component in the triple?


This specifies the ABI change for the entry point


https://reviews.llvm.org/D42711