[PATCH] D42082: Add DWARF for discriminated unions
Tom Tromey via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 31 09:26:23 PST 2018
tromey added a comment.
In https://reviews.llvm.org/D42082#993453, @aprantl wrote:
>
> One last thing: Can you please make sure that there is a binary bitcode upgrade test in test/Bitcode that exercises the upgrade from the older shorter version of DICompositeType in MetadataLoder.cpp and if not, add one? Thanks!
There is - an earlier version of the patch just checked for the new length, and testing showed failures, so those tests (unchanged by this patch) are why the code accepts the shorter version as well.
Repository:
rL LLVM
https://reviews.llvm.org/D42082
More information about the llvm-commits
mailing list