[PATCH] D42293: [TableGen][AsmMatcherEmitter] Fix tied-constraint checking for InstAliases

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 31 06:14:39 PST 2018


sdesmalen added inline comments.


================
Comment at: utils/TableGen/AsmMatcherEmitter.cpp:3669
   if (!ReportMultipleNearMisses) {
-    OS << "      SMLoc Loc;\n";
-    OS << "      if (!checkAsmTiedOperandConstraints(Inst, Operands, Loc)) {\n";
-    OS << "        ErrorInfo = " << (HasMnemonicFirst ? "1" : "SIndex") << ";\n";
+    OS << "      if (!checkAsmTiedOperandConstraints(it->ConvertFn, Operands, ErrorInfo))\n";
     OS << "        return Match_InvalidTiedOperand;\n";
----------------
olista01 wrote:
> If we are in a ReportMultipleNearMisses backend then this check will be skipped, so should we assert here?
Hi @olista01, my apologies, I didn't notice your comment earlier. I have addressed your concern in my latest patch.


https://reviews.llvm.org/D42293





More information about the llvm-commits mailing list