[PATCH] D42607: [LoopStrengthReduce, x86] don't add cost for a cmp that will be macro-fused (PR35681)

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 31 06:14:03 PST 2018


spatel added a comment.

In https://reviews.llvm.org/D42607#992829, @venkataramanan.kumar.llvm wrote:

> I ran SPEC2017 on Ryzen (c/c++ benchmarks) -O2 -fno-unroll-loops.  no significant change in performance with the patch.


Great - thank you for checking that. If there are no objections, I'll commit this so we get wider testing (or I can wait for more data to make sure there are no regressions).

That will allow more experimentation with other LSR changes (that might have more impact) without worrying about this case.


https://reviews.llvm.org/D42607





More information about the llvm-commits mailing list