[PATCH] D42481: [DebugInfo] Add basic support for DWARF 5 .debug_rnglists dumping

[James Henderson via Phabricator via llvm-commits]

jhenderson updated this revision to Diff 132142.
jhenderson marked 5 inline comments as done.
jhenderson added a comment.

Addressed review comments.

In switching to using Errors, I realised I could add several more errors producing finer grained error messages. To go along with that, I've also rewritten the tests quite a bit, mostly to combine the error message tests into a single test, and to test a couple of corner cases.

With this change, the behaviour is to try to keep going and parse other tables in the same section, as much as possible. In keeping with what happens with other debug sections, when there is an error with the .debug_rnglists parsing, llvm-dwarfdump still does not exit with a failure.


Repository:
  rL LLVM

https://reviews.llvm.org/D42481

Files:
  include/llvm/BinaryFormat/Dwarf.def
  include/llvm/DebugInfo/DWARF/DWARFDebugRnglists.h
  include/llvm/DebugInfo/DWARF/DWARFObject.h
  lib/DebugInfo/DWARF/CMakeLists.txt
  lib/DebugInfo/DWARF/DWARFContext.cpp
  lib/DebugInfo/DWARF/DWARFDebugRnglists.cpp
  test/tools/llvm-dwarfdump/X86/Inputs/debug_rnglists_short_section.s
  test/tools/llvm-dwarfdump/X86/Inputs/debug_rnglists_some_invalid.s
  test/tools/llvm-dwarfdump/X86/debug_rnglists.s
  test/tools/llvm-dwarfdump/X86/debug_rnglists_empty.s
  test/tools/llvm-dwarfdump/X86/debug_rnglists_invalid.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42481.132142.patch
Type: text/x-patch
Size: 25009 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180131/d1f51498/attachment-0001.bin>