[PATCH] D42661: [WebAssembly] Fix signature mismatches in test code. NFC.

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 30 20:19:02 PST 2018


sbc100 added a comment.

In https://reviews.llvm.org/D42661#992800, @ruiu wrote:

> I don't have enough knowledge to review this, but do you need a pre-commit code review for this?


Perhaps no review needed.   I tend to prefer pre-commit reviews for pretty much all changes, although I understand llvm is less strict about this than other projects.

I've been adding you you as a reviewer to pretty much all my changes, even these smaller ones, mostly just to keep you in the loop.  If you'd like to use other people for the more trivial changes I certainly can.  And also feel free to remove yourself from the reviewer list any time.. I won't be offended.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42661





More information about the llvm-commits mailing list