[PATCH] D42446: [ThinLTO] Add a couple of more knobs to C API to control cache size.

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added inline comments.


================
Comment at: include/llvm/LTO/legacy/ThinLTOCodeGenerator.h:169
 
+
   /**
----------------
extraneous new line


================
Comment at: include/llvm/LTO/legacy/ThinLTOCodeGenerator.h:190
+  /// over the amount of available space on the disk will be reduced to the
+  /// amount of available space. A value of 0 will be ignored.
+  void setCacheMaxSizeBytes(unsigned MaxSizeBytes) {
----------------
In CachePruning.h, a value of 0 for this field disables size based pruning. Why do something different here (which seems to go in the opposite direction from D42267)?


================
Comment at: tools/llvm-lto/llvm-lto.cpp:163
+static cl::opt<int>
+    ThinLTOCacheMaxSizeBytes("thinlto-cache-max-size-bytes", cl::desc("Set ThinLTO cache pruning directory maximum size in bytes."));
+
----------------
line too long


================
Comment at: tools/llvm-lto/llvm-lto.cpp:166
+static cl::opt<int>
+    ThinLTOCacheMaxSizeFiles("thinlto-cache-max-size-files", cl::init(100000), cl::desc("Set ThinLTO cache pruning directory maximum number of files."));
+
----------------
line too long


Repository:
  rL LLVM

https://reviews.llvm.org/D42446