[PATCH] D42511: [WebAssembly] Add support for --gc-sections

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

LGTM



================
Comment at: wasm/MarkLive.cpp:94-98
+    auto CheckChunk = [](const InputChunk *C) {
+      if (!C->Live)
+        message("removing unused section '" + C->getName() + "' in file '" +
+                C->getFileName() + "'");
+    };
----------------
sbc100 wrote:
> ruiu wrote:
> > I'd make this a file-scope function now. But on second thought, I'd just repeat it twice. It's not very beautiful but that's probably simpler than defining a function.
> I'd rather not repeat that ugly multi-line error string.  
> 
> ( I imagine we will unify this into a single list of input chunks at some point (like ELF does) so this should go away then anyway).
Sure. It'd be nice if we can unify the two lists.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42511