[PATCH] D42600: [WIP][Shrink-wrap]split restore point

Francis Visoiu Mistrih via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 30 17:36:48 PST 2018


thegameg added a comment.

In https://reviews.llvm.org/D42600#992723, @qcolombet wrote:

> Regarding the SESE approach, I think it wouldn't be enough because what you want and not given by SESE is *new* common (post)dominator. E.g., in the motivating example we wanted to merge (A->C) (B->C) into (A->common) (B->common) (common->C).


Yes, but if I understand the paper correctly, in Figure 4 (left) they basically create an SESE out of what they call "Set 1" in Figure 3 (depending on what they call "execution count cost model"). I read that part a while ago but I think at that point they are deciding whether to use "Region 1" as a save/restore boundary or to create a new SESE for that.


https://reviews.llvm.org/D42600





More information about the llvm-commits mailing list