[PATCH] D42082: Add DWARF for discriminated unions

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 30 11:50:02 PST 2018

Previous message: [PATCH] D42698: [GraphTraits] Add support for iterating over children edges.
Next message: [PATCH] D42082: Add DWARF for discriminated unions
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

aprantl added a comment.

As far as the metadata changes are concerned this looks mostly good, what's missing is a

- round-trip test of the assembler (similar to test/Assembler/dicompositetype-members.ll )\
- update DICompositeTypeTest in the unittests to test the hashing of the new field.


Repository:
  rL LLVM

https://reviews.llvm.org/D42082

Previous message: [PATCH] D42698: [GraphTraits] Add support for iterating over children edges.
Next message: [PATCH] D42082: Add DWARF for discriminated unions
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list