[PATCH] D41046: [ELF] Make overlapping output sections an error

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Writer.cpp:1880-1882
+    return "<emtpy range at 0x" + llvm::utohexstr(Address) + ">";
+  return "[0x" + llvm::utohexstr(Address) + " -> 0x" +
+         llvm::utohexstr(Address + Length - 1) + "]";
----------------
Remove `llvm::`.


================
Comment at: ELF/Writer.cpp:1885
+
+template <typename Getter, typename Predicate>
+static void checkForSectionOverlap(std::vector<OutputSection *> &AllSections,
----------------
It's not a trivial function, so it needs a function comment.


================
Comment at: ELF/Writer.cpp:1889-1890
+                                   Predicate ShouldSkip) {
+  auto FirstInteresting = partition(AllSections, ShouldSkip);
+  MutableArrayRef<OutputSection *> InterestingSections(AllSections);
+  InterestingSections = InterestingSections.slice(
----------------
Please do not use `auto` in lld unless the actual type is obvious in a very narrow context (e.g. RHS).


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D41046