[PATCH] D42622: [AggressiveInstCombine] fixed PR36121

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: lib/Transforms/AggressiveInstCombine/TruncInstCombine.cpp:335
+      if (Entry != Worklist.end()) {
+        if (auto *NewCI = dyn_cast<TruncInst>(Res))
           *Entry = NewCI;
----------------
Could these just be isa instead of dyn_cast? Doesn't look like you need a TruncInst to do any of the worklist changes.


================
Comment at: test/Transforms/AggressiveInstCombine/trunc_multi_uses.ll:223
+
+; Notice that there are two expression patters below:
+; 1. %T2->%C2->(%B2->(%T1, 15), %B2->(%T1, 15))
----------------
patters->patterns


================
Comment at: test/Transforms/AggressiveInstCombine/trunc_multi_uses.ll:247
+
+; Notice that there are two expression patters below:
+; 1. %T2->%C2->(%B2->(%T1, 15), %B2->(%T1, 15))
----------------
patters->patterns


https://reviews.llvm.org/D42622