[PATCH] D42671: Sort orphan section if --symbol-ordering-file is given
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 30 01:25:40 PST 2018
grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.
LGTM with nits.
================
Comment at: ELF/LinkerScript.cpp:252
// 4. If no SORT command is given, sort according to --sort-section.
// 5. If no SORT commands are given and --sort-section is not specified,
// apply sorting provided by --symbol-ordering-file if any exist.
----------------
5th comment's line is outdated after the change.
================
Comment at: ELF/Writer.cpp:1021
// If no layout was provided by linker script, we want to apply default
// sorting for special input sections and handle --symbol-ordering-file.
template <class ELFT> void Writer<ELFT>::sortInputSections() {
----------------
Its a bit inaccurate now, as sorting with --symbol-ordering-file is always applied with this change.
https://reviews.llvm.org/D42671
More information about the llvm-commits
mailing list