[llvm] r323726 - [ARM GlobalISel] Legalize G_FPTOSI and G_FPTOUI
Diana Picus via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 29 23:54:52 PST 2018
Author: rovka
Date: Mon Jan 29 23:54:52 2018
New Revision: 323726
URL: http://llvm.org/viewvc/llvm-project?rev=323726&view=rev
Log:
[ARM GlobalISel] Legalize G_FPTOSI and G_FPTOUI
Legal if we have hardware support for floating point, libcalls
otherwise.
Also add the necessary support for libcalls in the legalizer helper.
Modified:
llvm/trunk/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
llvm/trunk/lib/Target/ARM/ARMLegalizerInfo.cpp
llvm/trunk/test/CodeGen/ARM/GlobalISel/arm-legalize-fp.mir
Modified: llvm/trunk/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/GlobalISel/LegalizerHelper.cpp?rev=323726&r1=323725&r2=323726&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/GlobalISel/LegalizerHelper.cpp (original)
+++ llvm/trunk/lib/CodeGen/GlobalISel/LegalizerHelper.cpp Mon Jan 29 23:54:52 2018
@@ -150,6 +150,10 @@ static RTLIB::Libcall getConvRTLibDesc(u
return RTLIB::getFPEXT(FromMVT, ToMVT);
case TargetOpcode::G_FPTRUNC:
return RTLIB::getFPROUND(FromMVT, ToMVT);
+ case TargetOpcode::G_FPTOSI:
+ return RTLIB::getFPTOSINT(FromMVT, ToMVT);
+ case TargetOpcode::G_FPTOUI:
+ return RTLIB::getFPTOUINT(FromMVT, ToMVT);
}
llvm_unreachable("Unsupported libcall function");
}
@@ -219,6 +223,20 @@ LegalizerHelper::libcall(MachineInstr &M
if (Status != Legalized)
return Status;
break;
+ }
+ case TargetOpcode::G_FPTOSI:
+ case TargetOpcode::G_FPTOUI: {
+ // FIXME: Support other types
+ unsigned FromSize = MRI.getType(MI.getOperand(1).getReg()).getSizeInBits();
+ unsigned ToSize = MRI.getType(MI.getOperand(0).getReg()).getSizeInBits();
+ if (ToSize != 32 || (FromSize != 32 && FromSize != 64))
+ return UnableToLegalize;
+ LegalizeResult Status = conversionLibcall(
+ MI, MIRBuilder, Type::getInt32Ty(Ctx),
+ FromSize == 64 ? Type::getDoubleTy(Ctx) : Type::getFloatTy(Ctx));
+ if (Status != Legalized)
+ return Status;
+ break;
}
}
Modified: llvm/trunk/lib/Target/ARM/ARMLegalizerInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMLegalizerInfo.cpp?rev=323726&r1=323725&r2=323726&view=diff
==============================================================================
--- llvm/trunk/lib/Target/ARM/ARMLegalizerInfo.cpp (original)
+++ llvm/trunk/lib/Target/ARM/ARMLegalizerInfo.cpp Mon Jan 29 23:54:52 2018
@@ -134,9 +134,6 @@ ARMLegalizerInfo::ARMLegalizerInfo(const
setAction({G_PTRTOINT, s32}, Legal);
setAction({G_PTRTOINT, 1, p0}, Legal);
- setAction({G_FPTOSI, s32}, Legal);
- setAction({G_FPTOSI, 1, s32}, Legal);
-
for (unsigned Op : {G_ASHR, G_LSHR, G_SHL})
setAction({Op, s32}, Legal);
@@ -189,6 +186,12 @@ ARMLegalizerInfo::ARMLegalizerInfo(const
setAction({G_FPTRUNC, s32}, Legal);
setAction({G_FPTRUNC, 1, s64}, Legal);
+
+ for (unsigned Op : {G_FPTOSI, G_FPTOUI}) {
+ setAction({Op, s32}, Legal);
+ for (auto Ty : {s32, s64})
+ setAction({Op, 1, Ty}, Legal);
+ }
} else {
for (unsigned BinOp : {G_FADD, G_FSUB, G_FMUL, G_FDIV})
for (auto Ty : {s32, s64})
@@ -209,6 +212,12 @@ ARMLegalizerInfo::ARMLegalizerInfo(const
setAction({G_FPTRUNC, s32}, Legal);
setAction({G_FPTRUNC, 1, s64}, Libcall);
+ for (unsigned Op : {G_FPTOSI, G_FPTOUI}) {
+ setAction({Op, s32}, Legal);
+ setAction({Op, 1, s32}, Libcall);
+ setAction({Op, 1, s64}, Libcall);
+ }
+
if (AEABI(ST))
setFCmpLibcallsAEABI();
else
Modified: llvm/trunk/test/CodeGen/ARM/GlobalISel/arm-legalize-fp.mir
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/GlobalISel/arm-legalize-fp.mir?rev=323726&r1=323725&r2=323726&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/ARM/GlobalISel/arm-legalize-fp.mir (original)
+++ llvm/trunk/test/CodeGen/ARM/GlobalISel/arm-legalize-fp.mir Mon Jan 29 23:54:52 2018
@@ -29,6 +29,11 @@
define void @test_fpext_float_to_double() { ret void }
define void @test_fptrunc_double_to_float() { ret void }
+ define void @test_fptosi_float() { ret void }
+ define void @test_fptosi_double() { ret void }
+ define void @test_fptoui_float() { ret void }
+ define void @test_fptoui_double() { ret void }
+
define void @test_fcmp_true_s32() { ret void }
define void @test_fcmp_false_s32() { ret void }
@@ -812,6 +817,144 @@ body: |
%r0 = COPY %3(s32)
BX_RET 14, %noreg, implicit %r0
---
+---
+name: test_fptosi_float
+# CHECK-LABEL: name: test_fptosi_float
+legalized: false
+# CHECK: legalized: true
+regBankSelected: false
+selected: false
+tracksRegLiveness: true
+registers:
+ - { id: 0, class: _ }
+ - { id: 1, class: _ }
+body: |
+ bb.0:
+ liveins: %r0
+
+ ; CHECK-DAG: [[X:%[0-9]+]]:_(s32) = COPY %r0
+ %0(s32) = COPY %r0
+ ; HARD: [[R:%[0-9]+]]:_(s32) = G_FPTOSI [[X]]
+ ; SOFT-NOT: G_FPTOSI
+ ; SOFT: ADJCALLSTACKDOWN
+ ; SOFT-DAG: %r0 = COPY [[X]]
+ ; SOFT-AEABI: BL &__aeabi_f2iz, {{.*}}, implicit %r0, implicit-def %r0
+ ; SOFT-DEFAULT: BL &__fixsfsi, {{.*}}, implicit %r0, implicit-def %r0
+ ; SOFT: [[R:%[0-9]+]]:_(s32) = COPY %r0
+ ; SOFT: ADJCALLSTACKUP
+ ; SOFT-NOT: G_FPTOSI
+ %1(s32) = G_FPTOSI %0(s32)
+ ; CHECK: %r0 = COPY [[R]]
+ %r0 = COPY %1(s32)
+ BX_RET 14, %noreg, implicit %r0
+...
+---
+name: test_fptosi_double
+# CHECK-LABEL: name: test_fptosi_double
+legalized: false
+# CHECK: legalized: true
+regBankSelected: false
+selected: false
+tracksRegLiveness: true
+registers:
+ - { id: 0, class: _ }
+ - { id: 1, class: _ }
+ - { id: 2, class: _ }
+ - { id: 3, class: _ }
+body: |
+ bb.0:
+ liveins: %r0, %r1
+
+ ; CHECK-DAG: [[X0:%[0-9]+]]:_(s32) = COPY %r0
+ ; CHECK-DAG: [[X1:%[0-9]+]]:_(s32) = COPY %r1
+ %0(s32) = COPY %r0
+ %1(s32) = COPY %r1
+ ; HARD: [[X:%[0-9]+]]:_(s64) = G_MERGE_VALUES [[X0]]
+ %2(s64) = G_MERGE_VALUES %0(s32), %1(s32)
+ ; HARD: [[R:%[0-9]+]]:_(s32) = G_FPTOSI [[X]]
+ ; SOFT-NOT: G_FPTOSI
+ ; SOFT: ADJCALLSTACKDOWN
+ ; SOFT-DAG: %r{{[0-1]}} = COPY [[X0]]
+ ; SOFT-DAG: %r{{[0-1]}} = COPY [[X1]]
+ ; SOFT-AEABI: BL &__aeabi_d2iz, {{.*}}, implicit %r0, implicit %r1, implicit-def %r0
+ ; SOFT-DEFAULT: BL &__fixdfsi, {{.*}}, implicit %r0, implicit %r1, implicit-def %r0
+ ; SOFT: [[R:%[0-9]+]]:_(s32) = COPY %r0
+ ; SOFT: ADJCALLSTACKUP
+ ; SOFT-NOT: G_FPTOSI
+ %3(s32) = G_FPTOSI %2(s64)
+ ; CHECK: %r0 = COPY [[R]](s32)
+ %r0 = COPY %3(s32)
+ BX_RET 14, %noreg, implicit %r0
+...
+---
+name: test_fptoui_float
+# CHECK-LABEL: name: test_fptoui_float
+legalized: false
+# CHECK: legalized: true
+regBankSelected: false
+selected: false
+tracksRegLiveness: true
+registers:
+ - { id: 0, class: _ }
+ - { id: 1, class: _ }
+body: |
+ bb.0:
+ liveins: %r0
+
+ ; CHECK-DAG: [[X:%[0-9]+]]:_(s32) = COPY %r0
+ %0(s32) = COPY %r0
+ ; HARD: [[R:%[0-9]+]]:_(s32) = G_FPTOUI [[X]]
+ ; SOFT-NOT: G_FPTOUI
+ ; SOFT: ADJCALLSTACKDOWN
+ ; SOFT-DAG: %r0 = COPY [[X]]
+ ; SOFT-AEABI: BL &__aeabi_f2uiz, {{.*}}, implicit %r0, implicit-def %r0
+ ; SOFT-DEFAULT: BL &__fixunssfsi, {{.*}}, implicit %r0, implicit-def %r0
+ ; SOFT: [[R:%[0-9]+]]:_(s32) = COPY %r0
+ ; SOFT: ADJCALLSTACKUP
+ ; SOFT-NOT: G_FPTOUI
+ %1(s32) = G_FPTOUI %0(s32)
+ ; CHECK: %r0 = COPY [[R]]
+ %r0 = COPY %1(s32)
+ BX_RET 14, %noreg, implicit %r0
+...
+---
+name: test_fptoui_double
+# CHECK-LABEL: name: test_fptoui_double
+legalized: false
+# CHECK: legalized: true
+regBankSelected: false
+selected: false
+tracksRegLiveness: true
+registers:
+ - { id: 0, class: _ }
+ - { id: 1, class: _ }
+ - { id: 2, class: _ }
+ - { id: 3, class: _ }
+body: |
+ bb.0:
+ liveins: %r0, %r1
+
+ ; CHECK-DAG: [[X0:%[0-9]+]]:_(s32) = COPY %r0
+ ; CHECK-DAG: [[X1:%[0-9]+]]:_(s32) = COPY %r1
+ %0(s32) = COPY %r0
+ %1(s32) = COPY %r1
+ ; HARD: [[X:%[0-9]+]]:_(s64) = G_MERGE_VALUES [[X0]]
+ %2(s64) = G_MERGE_VALUES %0(s32), %1(s32)
+ ; HARD: [[R:%[0-9]+]]:_(s32) = G_FPTOUI [[X]]
+ ; SOFT-NOT: G_FPTOUI
+ ; SOFT: ADJCALLSTACKDOWN
+ ; SOFT-DAG: %r{{[0-1]}} = COPY [[X0]]
+ ; SOFT-DAG: %r{{[0-1]}} = COPY [[X1]]
+ ; SOFT-AEABI: BL &__aeabi_d2uiz, {{.*}}, implicit %r0, implicit %r1, implicit-def %r0
+ ; SOFT-DEFAULT: BL &__fixunsdfsi, {{.*}}, implicit %r0, implicit %r1, implicit-def %r0
+ ; SOFT: [[R:%[0-9]+]]:_(s32) = COPY %r0
+ ; SOFT: ADJCALLSTACKUP
+ ; SOFT-NOT: G_FPTOUI
+ %3(s32) = G_FPTOUI %2(s64)
+ ; CHECK: %r0 = COPY [[R]](s32)
+ %r0 = COPY %3(s32)
+ BX_RET 14, %noreg, implicit %r0
+...
...
name: test_fcmp_true_s32
# CHECK-LABEL: name: test_fcmp_true_s32
More information about the llvm-commits
mailing list