[PATCH] D40979: [DWARF] Allow duplication of tails with CFI instructions

[Francis Visoiu Mistrih via Phabricator via llvm-commits]

thegameg accepted this revision.
thegameg added a comment.
This revision is now accepted and ready to land.

This LGTM, thanks.

I just had one more question (it's not blocking this patch in any way):

If we end up duplicating a prologue like in the test case that r317726 broke, will the CFI be correct without Correct dwarf unwind information in function epilogue <https://reviews.llvm.org/D35844>? I know this patch is needed to fix the other patch, I'm just wondering if it's ok to commit them separately. Also we can argue that CFI unwind info is not entirely correct/complete today since the epilogue is not described at all.



================
Comment at: test/CodeGen/AArch64/taildup-cfi.ll:6
+; ModuleID = 'taildup-cfi.c'
+source_filename = "taildup-cfi.c"
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
----------------
You can get rid of these 2 lines.


Repository:
  rL LLVM

https://reviews.llvm.org/D40979