[PATCH] D42630: Add msan interceptors for readlinkat and name_to_handle_at
Vitaly Buka via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 29 16:49:15 PST 2018
vitalybuka added a comment.
LGTM if you add sanitizer_common/ tests
================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:6641
+ COMMON_INTERCEPTOR_READ_RANGE(ctx, path, REAL(strlen)(path) + 1);
+ res = REAL(readlink)(path, buf, bufsiz);
+ if (res > 0)
----------------
SSIZE_T res = REAL(readlink)(path, buf, bufsiz);
================
Comment at: test/msan/name_to_handle_at.cc:16
+ handle->handle_bytes = MAX_HANDLE_SZ;
+
+ int mount_id;
----------------
this test shouls stay here at it's msan specific
another test, with trivial function call, should be added under sanitizer_common/
sanitizer_common/ tests will be executed with other sanitizers
Repository:
rCRT Compiler Runtime
https://reviews.llvm.org/D42630
More information about the llvm-commits
mailing list