[PATCH] D42665: Extensions to the LLVM debug information metadata to support the Fortran language.
Adrian Prantl via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 29 15:55:43 PST 2018
aprantl added a comment.
Thank you very much for this patch!
In order to make this review manageable, could you please split out the review into one separate patch per feature you are adding?
There are no testcases covering the new features. Could you please add some?
Also note that we just recently extended DISubrange in LLVM: (see https://reviews.llvm.org/D41695 https://reviews.llvm.org/D41696 https://reviews.llvm.org/D41698). It would be good if your patch for Fortran array types could build on top of that.
Repository:
rL LLVM
https://reviews.llvm.org/D42665
More information about the llvm-commits
mailing list