[PATCH] D42652: [WebAssembly] Make function signature checks into warning

[Nicholas Wilson via Phabricator via llvm-commits]

ncw added a comment.

In https://reviews.llvm.org/D42652#991174, @sbc100 wrote:

> Mostly because turning it on breaks so much existing code.  For example, musl has several such issues in it, which would mean that most of our tests on the wasm waterfall would stop linking if we enable this today.  For what its worth this is completely off by default right now.   So unless you explictly ask for it the linker will be silent about these errors.
>
> I think it is a worthy goal to enable this by default one day.


Ah, now I see! Thanks.  There can't be many broken prototypes in Musl? I'm aware of one, where __libc_start_main is called with an intentionally wrong prototype, but that can be fixed with an arch-specific override. It's still a bit off if it currently works, since the resulting Wasm file won't be runnable if the types don't match.

Perhaps some of the errors are instances of the bug (https://bugs.llvm.org/show_bug.cgi?id=35385), which results in correct declarations getting a messed-up signature mismatch.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42652