[lld] r323691 - [DWARFv5] Re-enable dumping a line table with no CU.

Paul Robinson via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 29 12:57:43 PST 2018


Author: probinson
Date: Mon Jan 29 12:57:43 2018
New Revision: 323691

URL: http://llvm.org/viewvc/llvm-project?rev=323691&view=rev
Log:
[DWARFv5] Re-enable dumping a line table with no CU.

r323476 added support for DW_FORM_line_strp, and incorrectly made that
depend on having a DWARFUnit available.  We shouldn't be tracking
.debug_line_str in DWARFUnit after all.  After this patch, I can do an
NFC follow up and undo a bunch of the "plumbing" part of r323476.

Differential Revision: https://reviews.llvm.org/D42609

Modified:
    lld/trunk/ELF/InputFiles.cpp

Modified: lld/trunk/ELF/InputFiles.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputFiles.cpp?rev=323691&r1=323690&r2=323691&view=diff
==============================================================================
--- lld/trunk/ELF/InputFiles.cpp (original)
+++ lld/trunk/ELF/InputFiles.cpp Mon Jan 29 12:57:43 2018
@@ -124,10 +124,8 @@ template <class ELFT> void ObjFile<ELFT>
   // The second parameter is offset in .debug_line section
   // for compilation unit (CU) of interest. We have only one
   // CU (object file), so offset is always 0.
-  // FIXME: Provide the associated DWARFUnit if there is one.  DWARF v5
-  // needs it in order to find indirect strings.
   const DWARFDebugLine::LineTable *LT =
-      DwarfLine->getOrParseLineTable(LineData, 0, nullptr);
+      DwarfLine->getOrParseLineTable(LineData, 0, Dwarf, nullptr);
 
   // Return if there is no debug information about CU available.
   if (!Dwarf.getNumCompileUnits())




More information about the llvm-commits mailing list