[PATCH] D42006: AArch64: Omit callframe setup/destroy when not necessary

Mon Jan 29 10:31:07 PST 2018

MatzeB added a comment.

Of course reverting is fine. This whole commit was mostly motivated by `llvm/test/CodeGen/AArch64/big-callframe.ll` but you could simply `XFAIL` that test together with the revert.

I will revert later if you don't beat me to it.

In https://reviews.llvm.org/D42006#990011, @mcrosier wrote:

> Would it be possible to revert r322917 while we investigate the regressions?  We also identified a 3.61% regression in SPEC2006/bzip2, so here's to complete list of regressions we are currently seeing due to this change:
>
> With -O3 -fno-math-errno -ffp-contract=fast -fomit-frame-pointer -mcpu=falkor:
>
>   Spec2006/astar -3.25%
>   Spec2006/bzip2 -3.61%
>   Spec2006/povray -5.28%
>   Spec2017/povray -6.08%
>   
>
> With -O3 -flto -fuse-ld=gold -fno-math-errno -ffp-contract=fast -fwhole-program-vtables -fvisibility=hidden -fomit-frame-pointer -mcpu=falkor:
>
>   Spec2006/astar -4.20%
>   Spec2006/h264ref -2.15%
>    
>
> All tests were run on Falkor, but hopefully these issues can be reproduced on other targets.  Please let us know if you need any assistance reproducing, Matthias.
>
>   Chad
>

Repository:
  rL LLVM

https://reviews.llvm.org/D42006