[PATCH] D42366: [CodeGen] Fix generation of TBAA tags for may-alias accesses
Ivan Kosarev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 29 07:43:23 PST 2018
kosarev added inline comments.
================
Comment at: lib/CodeGen/CodeGenTBAA.h:67
/* BaseType= */ nullptr, /* AccessType= */ nullptr,
- /* Offset= */ 0, /* Size= */ 0);
+ /* Offset= */ 0, /* Size= */ UINT64_MAX);
}
----------------
rjmccall wrote:
> Hmm. I think you should talk this part over with Hal. If the size should be ignored then I think it's better to just leave this as 0; it's certainly easier to recognize 0 as a "size unknown" value.
Hal, in D41501 we use UINT64_MAX as the "unknown" size value. Should we do the same here?
Repository:
rL LLVM
https://reviews.llvm.org/D42366
More information about the llvm-commits
mailing list