[PATCH] D42541: [DeadArgumentElimination] Preserve llvm.dbg.values's first argument

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added inline comments.


================
Comment at: lib/IR/Metadata.cpp:419
     }
-    if (getLocalFunction(From) && getLocalFunction(To) &&
-        getLocalFunction(From) != getLocalFunction(To)) {
+    if (getLocalFunctionMetadata(From) && getLocalFunctionMetadata(To) &&
+        getLocalFunctionMetadata(From) != getLocalFunctionMetadata(To)) {
----------------
aprantl wrote:
> One of these checks is redundant. How about:
> 
> ```
> if (DISubprogram *FromSP = getLocalFunctionMetadata(From))
>   if (getLocalFunctionMetadata(To) == FromSP)
> 
> ```
@aprantl Thanks for your comments! Maybe it's better for this to go as separate NFC commit?


https://reviews.llvm.org/D42541