[PATCH] D42297: [DebugInfo] Basic .debug_names dumping support

[Pavel Labath via Phabricator via llvm-commits]

labath added inline comments.


================
Comment at: llvm/trunk/lib/DebugInfo/DWARF/DWARFAcceleratorTable.cpp:311
+  // Check that we can read the fixed-size part.
+  if (!AS.isValidOffset(*Offset + sizeof(Header) - 1))
+    return make_error<StringError>("Section too small: cannot read header.",
----------------
I fixed an error here in a follow-up (r323648), which I noticed when some buildbots started failing:
Originally `Header`, contained only the fixed-size part, but during review it grew into something more. So, I split the fixed-size part into a separate struct to enable the sizeof() expression here to work.

Let me know if you want me to handle this differently.


Repository:
  rL LLVM

https://reviews.llvm.org/D42297