[PATCH] D36311: [ThinLTO] Add GraphTraits for FunctionSummaries

Charles Saternos via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 28 18:33:27 PST 2018


ncharlie marked 7 inline comments as done.
ncharlie added inline comments.


================
Comment at: include/llvm/IR/ModuleSummaryIndex.h:1015
+/// Gets the first available function summary from a ValueInfo
+static FunctionSummary *getFrontFunctionSummary(ValueInfo V) {
+  FunctionSummary *F;
----------------
@tejohnson 

I just wanted to double check that this functionality for getting a FunctionSummary from a ValueInfo is sane. It expects the first value in the SummaryList to be either a FunctionSummary (in which case it returns it) or an AliasSummary (in which case it gets its aliasee, expecting a FunctionSummary).


https://reviews.llvm.org/D36311





More information about the llvm-commits mailing list