[PATCH] D41235: [DAGCOmbine] Ensure that (brcond (setcc ...)) is handled in a canonical manner.

Amaury SECHET via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 27 14:38:08 PST 2018


deadalnix added a comment.

@niravd After proposing https://reviews.llvm.org/D42615 , it seems like using test instead of bt is the right thing to do as it has higher throughput - unless more work is required to materialize the constant. There is a bug in the materialization of test that cause it to sometime create needless copy. This needs to be fixed, regardless of what this diff does. I think we should proceed with this one.


Repository:
  rL LLVM

https://reviews.llvm.org/D41235





More information about the llvm-commits mailing list