[PATCH] D42603: [COFF] Update comment to reflect link.exe behavior. NFC
Shoaib Meenai via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Jan 27 10:18:53 PST 2018
This revision was automatically updated to reflect the committed changes.
Closed by commit rL323598: [COFF] Update comment to reflect link.exe behavior. NFC (authored by smeenai, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D42603
Files:
lld/trunk/COFF/Writer.cpp
Index: lld/trunk/COFF/Writer.cpp
===================================================================
--- lld/trunk/COFF/Writer.cpp
+++ lld/trunk/COFF/Writer.cpp
@@ -581,9 +581,8 @@
continue;
// If a section isn't discardable (i.e. will be mapped at runtime),
// prefer a truncated section name over a long section name in
- // the string table that is unavailable at runtime. This is different from
- // what link.exe does, but finding ".eh_fram" instead of "/4" is useful
- // to libunwind.
+ // the string table that is unavailable at runtime. Note that link.exe
+ // always truncates, even for discardable sections.
if ((Sec->getPermissions() & IMAGE_SCN_MEM_DISCARDABLE) == 0)
continue;
Sec->setStringTableOff(addEntryToStringTable(Name));
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42603.131686.patch
Type: text/x-patch
Size: 793 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180127/bf6b5682/attachment.bin>
More information about the llvm-commits
mailing list