[PATCH] D42107: [ThinLTO] - Stop internalizing and drop non-prevailing symbols.

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson accepted this revision.
tejohnson added a comment.

LGTM with 2 minor suggestions.



================
Comment at: lib/LTO/LTO.cpp:432
+      // In case we have multiple modules with the same symbol
+      // we want to use IR name of the prevailing symbol.
+      if (GlobalRes.IRName.empty())
----------------
add something like "Otherwise, if we haven't seen a prevailing symbol, set the name so that we can later use it to check if there is any prevailing copy in IR."


================
Comment at: lib/LTO/LTO.cpp:433
+      // we want to use IR name of the prevailing symbol.
+      if (GlobalRes.IRName.empty())
+        GlobalRes.IRName = Sym.getIRName();
----------------
merge this into the else if condition


https://reviews.llvm.org/D42107