[PATCH] D42103: [LSR] Don't force bases of foldable formulae to the final type.

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added a comment.

Out-of-curiosity do you actually see codegen differences with that patch?



================
Comment at: lib/Transforms/Scalar/LoopStrengthReduce.cpp:5012
     if (!Ops.empty()) {
       Value *FullV = Rewriter.expandCodeFor(SE.getAddExpr(Ops), Ty);
       Ops.clear();
----------------
I believe we would have the same problem here.


================
Comment at: lib/Transforms/Scalar/LoopStrengthReduce.cpp:5022
   if (!Ops.empty()) {
     Value *FullV = Rewriter.expandCodeFor(SE.getAddExpr(Ops), Ty);
     Ops.clear();
----------------
And here.


https://reviews.llvm.org/D42103