[PATCH] D42411: [test-suite] Fix ambigous call to overloaded function isnan
Simon Dardis via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 26 12:19:57 PST 2018
sdardis added a comment.
> I'm fine with leaving the code in the test-suite as is (no need for this followup patch).
Ah, I think I might have lead you to believe I had committed the previous version of this patch, which just used:
::isnan
to work around the failure with glibc.
> Update as per @MatzeB 's comment, checking before commit showed it broke the build on OSX.
Here I should have stated that I checked building the test-suite on OSX before committing the previous version of this patch but when I saw it broke the build with on OSX, I did not commit that version and posted the current version which is against trunk.
My apologies.
Repository:
rT test-suite
https://reviews.llvm.org/D42411
More information about the llvm-commits
mailing list