[PATCH] D42501: [dsymutil] Generate Apple accelerator tables
Jonas Devlieghere via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 26 12:01:39 PST 2018
JDevlieghere marked an inline comment as done.
JDevlieghere added inline comments.
================
Comment at: tools/dsymutil/CMakeLists.txt:4
AsmPrinter
+ BinaryFormat
DebugInfoDWARF
----------------
JDevlieghere wrote:
> aprantl wrote:
> > JDevlieghere wrote:
> > > aprantl wrote:
> > > > What's the dependency that makes this necessary?
> > > The call to `dwarf::djbHash()`
> > That is silly :-) and dsymutil is already huge.
> >
> > MD5 is in Support, so let's this function to Support too, and remove it from the dwarf namespace.
> Yesterday I noticed that there’s another use that needed this. Anyway, it will trigger a linker error and I’ll see if I can move that into support too.
D42594: Move DJB hash to support.
https://reviews.llvm.org/D42501
More information about the llvm-commits
mailing list