[PATCH] D42582: [lldb][PPC64] Fixed step-in stopping in the wrong line

[Greg Clayton via Phabricator via llvm-commits]

clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

This seems like functionality that should go into an architecture plug-in. The class is currently "lldb_private::Architecture". For an example see the ARM version:

  lldb/source/Plugins/Architecture/Arm/ArchitectureArm.h
  lldb/source/Plugins/Architecture/Arm/ArchitectureArm.cpp

We will need to add a new virtual call to lldb_private::Architecture with a default implementation that does nothing. Then you can add a PPC plug-in and do this work there.

You would get hold of the architecture plugin via the target:

  Architecture *architecture = target->GetArchitecturePlugin();
  if (architecture) { // Not all architectures have plug-ins, just ARM and soon PPC
    bytes_to_skip = architecture->GetBytesToSkip(this);


Repository:
  rL LLVM

https://reviews.llvm.org/D42582