[PATCH] D41939: [LV] Fix incorrect detection of type-promoted Phis

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added inline comments.


================
Comment at: lib/Transforms/Utils/LoopUtils.cpp:372
+        // Two users outside the loop, we should not have it.
+        // TODO: Can this be safely replaced with assert?
+        if (LCSSAPhi)
----------------
anna wrote:
> I don't think you can assert since you can have uses of `ExitInstruction` in unreachable blocks and unreachable blocks by definition are outside a loop.
Good point, thanks!


https://reviews.llvm.org/D41939