[PATCH] D42527: [DebugInfo] Fix fragment offset emission order for symbol locations

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 26 04:11:37 PST 2018


JDevlieghere added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp:232
     }
-    if (Expr) {
-      DwarfExpr->addFragmentOffset(Expr);
+    if (Expr)
       DwarfExpr->addExpression(Expr);
----------------
Just from looking at the code, as neither `Expr` nor `DwarfExpr` are used in the if-clause above, can we move up this part too?


Repository:
  rL LLVM

https://reviews.llvm.org/D42527





More information about the llvm-commits mailing list