[PATCH] D42439: [GISel]: Pattern Match helpers for MachineInstructions

Aditya Nandakumar via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 25 19:36:36 PST 2018


Hey Vedant
I fixed this in rL323487. Please let me know if that doesn’t fix it.

Thanks
Aditya
Sent from my iPhone

> On Jan 25, 2018, at 6:17 PM, Vedant Kumar via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> vsk added inline comments.
> 
> 
> ================
> Comment at: include/llvm/CodeGen/GlobalISel/MIPatternMatch.h:57
> +
> +ConstantMatch m_ICst(uint64_t &Cst) { return ConstantMatch(Cst); }
> +
> ----------------
> Does this need to be static inline?
> 
> 
> https://reviews.llvm.org/D42439
> 
> 
> 


More information about the llvm-commits mailing list