[PATCH] D41658: [RISCV] Encode RISCV specific ELF e_flags to RISCV Binary by RISCVTargetStreamer

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 26 00:39:31 PST 2018


asb added a comment.

Hi Shiva. In the future it's worth nothing that if you include the review url in the commit, then Phabricator automatically picks it up.

e.g. if you included this line then phabricator would automatically close this review:
Differential Revision: https://reviews.llvm.org/D41658

It looks like you missed the minor sorting/whitespace fixes I suggested https://reviews.llvm.org/D41658#978491. If you have time to commit a follow-up cleanup I'd appreciate it (just committing directly for this cleanup is fine). Thanks!


Repository:
  rL LLVM

https://reviews.llvm.org/D41658





More information about the llvm-commits mailing list