[llvm] r323493 - Reland "[llvm-objcopy] Refactor llvm-objcopy to use reader and writer objects"

Jake Ehrlich via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 25 17:48:12 PST 2018


Author: jakehehrlich
Date: Thu Jan 25 17:48:12 2018
New Revision: 323493

URL: http://llvm.org/viewvc/llvm-project?rev=323493&view=rev
Log:
Reland "[llvm-objcopy] Refactor llvm-objcopy to use reader and writer objects"

I had more unused varibles. This change removes those to get rid of warnings.

Modified:
    llvm/trunk/tools/llvm-objcopy/Object.cpp

Modified: llvm/trunk/tools/llvm-objcopy/Object.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-objcopy/Object.cpp?rev=323493&r1=323492&r2=323493&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-objcopy/Object.cpp (original)
+++ llvm/trunk/tools/llvm-objcopy/Object.cpp Thu Jan 25 17:48:12 2018
@@ -698,13 +698,13 @@ ELFReader::ELFReader(StringRef File) {
 }
 
 ElfType ELFReader::getElfType() const {
-  if (auto *o = dyn_cast<ELFObjectFile<ELF32LE>>(Binary.get()))
+  if (isa<ELFObjectFile<ELF32LE>>(Binary.get()))
     return ELFT_ELF32LE;
-  if (auto *o = dyn_cast<ELFObjectFile<ELF64LE>>(Binary.get()))
+  if (isa<ELFObjectFile<ELF64LE>>(Binary.get()))
     return ELFT_ELF64LE;
-  if (auto *o = dyn_cast<ELFObjectFile<ELF32BE>>(Binary.get()))
+  if (isa<ELFObjectFile<ELF32BE>>(Binary.get()))
     return ELFT_ELF32BE;
-  if (auto *o = dyn_cast<ELFObjectFile<ELF64BE>>(Binary.get()))
+  if (isa<ELFObjectFile<ELF64BE>>(Binary.get()))
     return ELFT_ELF64BE;
   llvm_unreachable("Invalid ELFType");
 }




More information about the llvm-commits mailing list